fix: avoid ERR_REQUIRE_ESM during reflex export with rx.code_block#6055
Open
daeunnniii wants to merge 1 commit intoreflex-dev:mainfrom
Open
fix: avoid ERR_REQUIRE_ESM during reflex export with rx.code_block#6055daeunnniii wants to merge 1 commit intoreflex-dev:mainfrom
daeunnniii wants to merge 1 commit intoreflex-dev:mainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryFixed Key Changes:
Technical Context: Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant ReflexExport as reflex export
participant Vite as Vite Build
participant RSH as react-syntax-highlighter
participant Refractor as refractor (ESM)
User->>ReflexExport: Run reflex export
ReflexExport->>Vite: Trigger npm run export
Note over Vite: config.command === "build"
alt Before Fix (externalized)
Vite->>RSH: External import (Node.js resolution)
RSH->>Refractor: require() ESM module
Refractor-->>RSH: ERR_REQUIRE_ESM
RSH-->>Vite: Build fails
Vite-->>User: Export fails
end
alt After Fix (noExternal)
Vite->>Vite: Bundle react-syntax-highlighter & refractor
Note over Vite: Handles ESM/CJS interop internally
Vite->>RSH: Bundled import
RSH->>Refractor: Bundled ESM import
Refractor-->>RSH: Success
RSH-->>Vite: Success
Vite-->>User: Export succeeds
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6054
Solution
Updated the generated Vite configuration to prevent SSR build externalization of
react-syntax-highlighterand its ESM dependencyrefractor.This ensures that during
reflex export, Vite/Rolldown handles ESM/CJS interopcorrectly instead of deferring module resolution to Node.js, which caused
ERR_REQUIRE_ESMfailures on Node.js 21+.The change is scoped to the build/export phase only and does not affect development mode.
Changes Made
react-syntax-highlighterduring export buildsrefractorto the non-externalized dependency list to avoid ESM/CJS conflictsAll Submissions:
Type of change
Please delete options that are not relevant.
Changes To Core Features: