0828dev

[adhami3310]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

✅ 8 untouched benchmarks

---

_{Comparing 0828dev (5530a4a) with main (88155a7)}

[greptile-apps]

Greptile Summary

This is a routine dev-cycle dependency update PR bumping the reflex version from 0.8.27dev1 to 0.8.28dev1, updating a broad set of frontend dependencies (lucide-react, recharts, react-dropzone, radix-ui/themes, react-moment, react-error-boundary, lodash, Bun, vite, react-router, autoprefixer, isbot), adding new Lucide icons, a new from_now_short prop to the Moment component, and fixing floating-point comparison flakiness in unit tests.

Key changes:

• Frontend deps bumped: lucide-react 0.574.0, recharts 3.7.0, react-dropzone 15.0.0 (major bump), @radix-ui/themes 3.3.0, react-moment 1.2.2, Bun 1.3.9
• Vite switched: from the npm:rolldown-vite@7.3.1 alias to native vite@8.0.0-beta.14; the corresponding OVERRIDES entry is also removed — a beta version in the default dependency set may affect user stability
• New icons: ~15 new icons added to LUCIDE_ICON_LIST including database_search, git_merge_conflict, globe_off, globe_x, user_key, user_round_key, etc.
• Moment from_now_short: new prop exposes the abbreviated relative-time format ("1h" instead of "1 hour ago")
• Recharts Brush cleanup: removed duplicate (un-defaulted) fill/stroke prop definitions that shadowed already-defined defaulted versions earlier in the class
• Recharts LiteralPolarRadiusType: adds "auto" to match recharts 3.7.0 API
• Test fixes: math.isclose() used throughout for float equality, preventing precision-related flakiness
• Commented-out code: # "mouse_right" left at the end of LUCIDE_ICON_LIST should be removed before merging

Confidence Score: 4/5

• This PR is generally safe to merge, with one notable concern around pinning a beta version of vite as the default build tool for all Reflex users.
• The bulk of changes are straightforward dependency bumps, icon additions, and test quality improvements. The two items that warrant attention are: (1) vite@8.0.0-beta.14 is a pre-release version being set as the default for all users — if the beta introduces instability it could affect many users; and (2) a commented-out list entry (# "mouse_right") should be removed per project conventions. The react-dropzone major version bump (14→15) and recharts bump (3.6→3.7) appear compatible with existing API usage but have not been verified against full integration test suites in this diff.
• reflex/constants/installer.py (vite beta version) and reflex/components/lucide/icon.py (commented-out code)

Important Files Changed

Filename	Overview
reflex/components/lucide/icon.py	Bumps lucide-react from 0.562.0 to 0.574.0 and adds ~15 new icons to LUCIDE_ICON_LIST. One minor concern: a commented-out entry # "mouse_right" is present at the end of the list, which should be removed before merging.
reflex/components/moment/moment.py	Bumps react-moment from 1.2.0 to 1.2.2 and adds a new from_now_short prop. The pyi_hashes.json for moment.pyi was not updated, but the pyi generator will regenerate it when run automatically.
reflex/components/recharts/cartesian.py	Removes duplicate fill and stroke prop definitions from the Brush class that were already defined higher up in the class (with defaults). This is a clean deduplication fix, not a loss of functionality.
reflex/components/recharts/recharts.py	Bumps recharts from 3.6.0 to 3.7.0 and adds "auto" to LiteralPolarRadiusType to match the new recharts API. Both Recharts base classes are updated consistently.
reflex/constants/installer.py	Multiple dependency bumps: Bun 1.3.9, react-router 7.13.0, isbot 5.1.35, autoprefixer 10.4.24, and critically switches vite from npm:rolldown-vite@7.3.1 to 8.0.0-beta.14 (standard vite beta) and removes the vite override entry. The use of a beta version of vite in the default dependency set is a potential stability concern.
reflex/components/core/upload.py	Bumps react-dropzone from 14.3.8 to 15.0.0 (major version). The API appears consistent with current usage (useDropzone hook), but major version bumps can include breaking changes.

Flowchart

flowchart TD
    A[PR #6136: 0828dev] --> B[Dependency Bumps]
    A --> C[New Features]
    A --> D[Bug Fixes]
    A --> E[Cleanup]

    B --> B1[lucide-react 0.562.0 → 0.574.0]
    B --> B2[react-moment 1.2.0 → 1.2.2]
    B --> B3[recharts 3.6.0 → 3.7.0]
    B --> B4[react-dropzone 14.3.8 → 15.0.0]
    B --> B5[radix-ui/themes 3.2.1 → 3.3.0]
    B --> B6[react-error-boundary 6.1.0 → 6.1.1]
    B --> B7[lodash 4.17.21 → 4.17.23]
    B --> B8[vite: rolldown-vite@7.3.1 → 8.0.0-beta.14]
    B --> B9[Bun 1.3.6 → 1.3.9]

    C --> C1[15 new icons in LUCIDE_ICON_LIST]
    C --> C2[Moment: from_now_short prop added]
    C --> C3[Recharts: LiteralPolarRadiusType adds 'auto']

    D --> D1[Tests: math.isclose for float comparisons]
    D --> D2[Recharts Brush: remove duplicate fill/stroke props]

    E --> E1[Remove vite from OVERRIDES]
    E --> E2[Version bump: 0.8.27dev1 → 0.8.28dev1]

Loading

_{Last reviewed commit: 5530a4a}

[greptile-apps]

_{15 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Commented-out code should be removed

# "mouse_right" is left as a comment at the end of LUCIDE_ICON_LIST. If the icon is intentionally excluded (e.g. it doesn't yet exist in lucide-react@0.574.0 or has a non-standard export name that requires an override), it should either be removed entirely or tracked in an issue — not left as a commented-out entry in the list. Per the project's code review guidelines, commented-out code should be removed before merging.

Suggested change

	# "mouse_right",
	"zoom_out",
	]

Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

[greptile-apps]

Beta version in production default dependencies

vite@8.0.0-beta.14 is a pre-release version. Using a beta in the default dependency set means all Reflex users will install a potentially unstable build tool. If this is intentional (e.g. vite 8 beta is required for rolldown support or another feature), it would be worth adding a comment explaining the reasoning, similar to how react-is has an explanation above it.

If stability is a concern, prefer pinning to a stable release once vite 8.0.0 is final, or keep the npm:rolldown-vite alias in the meantime.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

[masenf]

were these removed upstream? i wonder if we need some kind of warning to any users that were passing these props?

[adhami3310]

they are defined above, ruff was flagging it