Unlink broken symlinks in the assets folder

[masenf]

Certain build environments, such as docker bind mounts, can create symlinks that exist, but cannot be overwritten for whatever reason. So we unlink those for Simon 🎁

[codspeed-hq]

Merging this PR will not alter performance

✅ 8 untouched benchmarks

---

_{Comparing masenf/unlink-bad-symlinks (644a2bb) with main (88155a7)}

[greptile-apps]

Greptile Summary

Added error handling for FileExistsError when creating symlinks in the assets folder, specifically to handle broken symlinks in Docker bind mount environments.

• Wrapped dst_file.symlink_to() in try-catch block
• On FileExistsError, unlinks the existing path and recreates the symlink
• Solves issue where broken symlinks cannot be overwritten in certain build environments

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The change is a focused bug fix for a specific Docker environment issue. The try-catch error handling is appropriate, though there's a minor edge case around race conditions that could be made more robust by verifying it's a symlink before unlinking
• No files require special attention

Important Files Changed

Filename	Overview
reflex/assets.py	Added try-catch to handle FileExistsError when creating symlinks in Docker environments; potential edge case with race conditions

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Check if dst_file exists and symlink is valid] --> B{Needs new symlink?}
    B -->|No| C[Return asset path]
    B -->|Yes| D[Try to create symlink]
    D --> E{FileExistsError?}
    E -->|No| C
    E -->|Yes| F[Unlink existing path]
    F --> G[Create symlink]
    G --> C

Loading

_{Last reviewed commit: 644a2bb}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Catching FileExistsError and blindly unlinking could be risky if a race condition creates a legitimate file between the check on line 92 and the symlink creation. Consider checking dst_file.is_symlink() before unlinking to ensure you're only removing symlinks:

Suggested change

	except FileExistsError:
	# This happens when Simon builds the app on a bind mount in a docker container.
	dst_file.unlink()
	dst_file.symlink_to(src_file_shared)
	except FileExistsError:
	# This happens when Simon builds the app on a bind mount in a docker container.
	if dst_file.is_symlink():
	dst_file.unlink()
	dst_file.symlink_to(src_file_shared)
	else:
	raise