[REF-1455]fix: Add missing body parameter to skill publish endpoint#2228
Open
alchemistklk wants to merge 1 commit intomainfrom
Open
[REF-1455]fix: Add missing body parameter to skill publish endpoint#2228alchemistklk wants to merge 1 commit intomainfrom
alchemistklk wants to merge 1 commit intomainfrom
Conversation
The publish endpoint was ignoring the skillContent sent by CLI because the controller wasn't accepting or passing the request body to the service. This caused: - CLI's skillContent with workflowId to be discarded - Service to fall back to generating SKILL.md with placeholder 'see-workflow-mapping' - GitHub PRs to have incorrect workflowId - Metadata updates from SKILL.md to be skipped Changes: - Add PublishSkillDto to controller imports - Add @Body() parameter to publishSkill method - Pass body to skillPackageService.publishSkillPackage() Now when CLI sends { skillContent }, it will be properly received and used to update skill metadata and create GitHub PRs with correct workflowId. Fixes: All CLI skill publish operations since 2026-01-22 (commit afc49fe) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughA PublishSkillDto parameter was added as an optional argument to the publishSkill endpoint in the skill-package controller, forwarding it to the service layer. The PublishSkillDto type was also exported from the skill-package.dto module. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The skill publish API Controller was not accepting the
skillContentparameter from the request body, causing:skillContentwas ignoredworkflowId: see-workflow-mappingFix Details
Modified Files
apps/api/src/modules/skill-package/skill-package.controller.tsChanges
PublishSkillDtoto imports@Body() body?: PublishSkillDtoparameterbodytopublishSkillPackage()service methodImpact
Before Fix
After Fix
Scope
Testing
Related Issue
Fixes bug introduced in commit
afc49fed4(2026-01-22), which created the publish endpoint but missed the body parameter.Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Summary by CodeRabbit