[feat] Support custom indexed and external references#3630
Open
vkarak wants to merge 2 commits intoreframe-hpc:developfrom
Open
[feat] Support custom indexed and external references#3630vkarak wants to merge 2 commits intoreframe-hpc:developfrom
vkarak wants to merge 2 commits intoreframe-hpc:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3630 +/- ##
===========================================
+ Coverage 91.38% 91.45% +0.06%
===========================================
Files 62 62
Lines 13520 13675 +155
===========================================
+ Hits 12355 12506 +151
- Misses 1165 1169 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the test's
referencesyntax to support arbitrary indexing on test attributes as well as other configuration parameters, such as the current partition, environment, processor and/or device details. If no special indexing is requested, the reference dictionary behaves exactly as before.Support for external reference files is also added, where the reference dict of a test can be in an external YAML file.
Check the docs for all the details of the new features.
Implementation details
The test's prefix is now passed as a metaclass parameter and is not set during the test's initialization. This was needed to support the default external reference prefix, which coincides with the test's prefix, so we needed the test's prefix to be available during class creation and when the
referenceis defined in the test class body.Closes #3463