Conversation
Add the HPE vendor with the "HPE Bid (XLSX)" format, mirroring HP Bid:
Part Number / Bundle / BundleDetails rows over the ANZ-GENERIC template
with No Calculation + Uplift export options.
- New HpeBidXlsxParser anchored on "LineType"; vpn from ProductNumber /
BundleID / ComponentID (OptionCode ignored); msrp from ListPrcEst, cost
from Offering, qty from Quantity, min_qty from MinOrderQty (0->1),
comments "Max Qty: {MaxDealQty}" on parents; BundleDetails msrp/cost
drop to the 0.0001 sentinel.
- Constants (Vendors.Hpe, ParserSlugs.HpeBidXlsx, ReportTypes Hardware SOH)
and registry entry.
- AnzGenericWriter: route the MSRP write through NonZeroPrice (null-guarded;
HP/Lenovo stay blank) so HPE zero MSRPs export as the sentinel.
- WPF MainViewModel: show the Uplift margin field for HPE.
- Frontend sample-file map entry.
- Parser + writer golden tests, two fixtures + four goldens.
- Docs: new hpe_bid_xlsx.md, output_mapping + project_memory + CLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new vendor HPE with the HPE Bid (XLSX) format, mirroring the existing HP Bid format:
Part Number/Bundle/BundleDetailsrows written to the shared ANZ-GENERIC template with the No Calculation and Uplift export options.Changes
HpeBidXlsxParser— anchored onLineType; vpn fromProductNumber/BundleID/ComponentID(OptionCode ignored);msrpfromListPrcEst,costfromOffering,qtyfromQuantity,min_qtyfromMinOrderQty(0→1); commentsMax Qty: {MaxDealQty}on Part Number/Bundle lines; BundleDetails msrp/cost drop to the0.0001sentinel. Nested sequences (1,2,1.01…), AUD, no quoted total.Vendors.Hpe,ParserSlugs.HpeBidXlsx,ReportTypes→Hardware SOH, registry entry.NonZeroPrice(null-guarded; HP/Lenovo stay blank) so HPE zero MSRPs export as the sentinel, keeping the constant as a single source of truth.MainViewModelshows the Uplift margin field for HPE.HpeBidXlsxParserTests+ 4TemplateWriterTestsgolden rows; two input fixtures + four goldens; updatedParserRegistryTests.docs/hpe_bid_xlsx.md; updatedoutput_mapping.md,project_memory.md,CLAUDE.md.Testing
dotnet test BidParser.Parsing.Tests— 178/178 pass.dotnet build BidParser.slnanddotnet build BidParser.Core— clean.npm run build(frontend) — clean.Notes
MainViewModel.cs,net10.0-windows) could not be compiled in the Linux dev env — needs a build check on Windows.JL087Aappears on two rows) — expected per the agreed "base ID only" rule.