docs: add fork sync and measured PR workflow#28
docs: add fork sync and measured PR workflow#28brawlaphant wants to merge 1 commit intoregen-network:mainfrom
Conversation
Summary of ChangesHello @brawlaphant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's contribution guidelines by introducing a structured workflow for contributors utilizing a fork-based development model. The added documentation aims to streamline the process of keeping local branches synchronized with the main repository and encourages the creation of small, focused pull requests for easier review and integration. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new section to CONTRIBUTING.md detailing a Git workflow for contributors using forks. The workflow is well-structured and promotes good practices. I have a couple of suggestions to improve the clarity, consistency, and safety of the provided Git commands.
| git remote add upstream https://github.com/regen-network/agentic-tokenomics.git | ||
| 2. Sync local main: | ||
| git checkout main | ||
| git fetch upstream origin |
There was a problem hiding this comment.
The command git fetch upstream origin fetches from both the upstream and origin remotes. For clarity and consistency with step 5 (which uses git fetch upstream), it's better to fetch only from upstream. The subsequent command git reset --hard upstream/main only requires changes from the upstream remote, making the fetch from origin unnecessary for this step.
| git fetch upstream origin | |
| git fetch upstream |
| 2. Sync local main: | ||
| git checkout main | ||
| git fetch upstream origin | ||
| git reset --hard upstream/main |
There was a problem hiding this comment.
The git reset --hard command is destructive as it discards any local commits on the main branch. It would be helpful to add a comment to explicitly warn contributors about this, reinforcing the idea that development work should be done on separate feature branches, not on main.
| git reset --hard upstream/main | |
| # WARNING: This command discards any local changes and commits on your main branch. | |
| git reset --hard upstream/main |
No description provided.