Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ struct AndroidDeviceScreenStateReader: AndroidDeviceScreenStateReading {
}

private func resumedApplicationIdentifier(from output: String) -> String? {
guard let line = output
.split(whereSeparator: \Character.isNewline)
.first(where: { $0.contains("topResumedActivity=") }) else {
let lines = output.split(whereSeparator: \Character.isNewline)
let line = lines.first(where: { $0.contains("topResumedActivity=") })
?? lines.first(where: { $0.contains("mResumedActivity:") })
guard let line else {
return nil
}
return line
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,26 @@ final class AndroidScreenshotProviderTests: XCTestCase {
])
}

func testScreenStateReaderResolvesLegacyAndroidResumedActivity() throws {
let runner = ScreenshotADBCommandRunner(results: [
commandOutput(
"mResumedActivity: ActivityRecord{1553f2c u0 com.example.demo/.MainActivity t31}\n"
),
commandOutput("mShowingLockscreen=false\n")
])
let reader = AndroidDeviceScreenStateReader(
adbClient: ADBClient(commandRunner: runner)
)

let state = try reader.read(deviceSerial: "emulator-5554")

XCTAssertEqual(
state.foregroundApplicationIdentifier,
"com.example.demo"
)
XCTAssertFalse(state.locked)
}

func testProviderRejectsTargetIdentifierFromAnotherDevice() throws {
let provider = AndroidSystemScreenshotProvider(
adbClient: ADBClient(commandRunner: ScreenshotADBCommandRunner(results: []))
Expand Down Expand Up @@ -151,7 +171,10 @@ final class AndroidScreenshotProviderTests: XCTestCase {

func testProviderRejectsCaptureWhenFocusedAppCannotBeResolved() throws {
let runner = ScreenshotADBCommandRunner(results: [
commandOutput("topResumedActivity=null\n"),
commandOutput("""
topResumedActivity=null
mResumedActivity: ActivityRecord{42 u0 com.example.demo/.MainActivity t1}
"""),
commandOutput("isStatusBarKeyguard=false\n")
])
let provider = AndroidSystemScreenshotProvider(
Expand Down
273 changes: 65 additions & 208 deletions skills/astrolabe/SKILL.md

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions skills/astrolabe/agents/openai.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
interface:
display_name: "Astrolabe UI Inspector"
short_description: "Verify a running mobile app UI against design contracts and Runtime evidence"
default_prompt: "Use Astrolabe MCP to observe the real target state, prepare it only through authorized visible UI or developer assistance, capture a fresh acceptance snapshot, and verify design contracts, rendered content, styles, UI relations, and screenshots with capability-driven evidence."
display_name: "Astrolabe UI Inspection"
short_description: "Inspect running mobile app UIs and review design consistency"
default_prompt: "Use $astrolabe to inspect a currently running app, wait for the developer to prepare the target state, collect node properties and screenshots read-only, and report differences from the supplied design references."
151 changes: 21 additions & 130 deletions skills/astrolabe/evals/evals.json

Large diffs are not rendered by default.

167 changes: 0 additions & 167 deletions skills/astrolabe/references/design-verification.md

This file was deleted.

89 changes: 0 additions & 89 deletions skills/astrolabe/references/rendered-content.md

This file was deleted.

34 changes: 0 additions & 34 deletions skills/astrolabe/references/temporary-patches.md

This file was deleted.

Loading