feat: allows to set screen geometry#14
Open
amachado-pie wants to merge 1 commit into
Open
Conversation
Owner
|
I'm not sure that I understand the use case for this feature. Are you saying that you have a touchscreen surface that does not cover the entire monitor surface, so you need to reduce the calibration area? |
Author
|
@reinderien You have two monitors in extended mode, which the system treats as one large workspace. Only the second monitor is a touchscreen, so you need to set the X offset where the touchscreen area begins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have multiple monitors, and only one of them is a touchscreen, we have to be able to define the width, height, xoffset yoffset of the area that will actually be used by the touch screen to create the calibration window.
Example if we have two 800x600 monitors X-Window will be considered as a screen size of width x height: 1600x600, creating a cambas with "1600x600" geometry
However, the touchscreen monitor is X-offset 800, so the correct geometry should be "800x600+800+0"
This PR allows you to override and introduce the detected screen width and height and indicate the XOFF and YOFF offset values that will be used by Canvas for calibration.
Example based on two 800x600 monitors, where the touchsreen is at xoffset 800: