fix: remove blade-capture-directive from test providers [2.x]#116
Merged
ManukMinasyan merged 1 commit into2.xfrom Mar 18, 2026
Merged
fix: remove blade-capture-directive from test providers [2.x]#116ManukMinasyan merged 1 commit into2.xfrom
ManukMinasyan merged 1 commit into2.xfrom
Conversation
Filament dropped ryangjchandler/blade-capture-directive as a dependency. Remove the explicit service provider registration from TestCase since the package is no longer installed.
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test harness by removing the unused BladeCaptureDirective service provider from the package test setup, reducing unnecessary dependencies during test bootstrapping.
Changes:
- Removed the
BladeCaptureDirectiveServiceProviderimport fromtests/TestCase.php. - Removed
BladeCaptureDirectiveServiceProvider::classfrom the registered package providers list intests/TestCase.php.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
BladeCaptureDirectiveServiceProviderfromtests/TestCase.php.Root Cause
Filament dropped
ryangjchandler/blade-capture-directiveas a dependency. The CI workflow runscomposer update --prefer-stablewhich resolves to a Filament version without this package. SinceTestCase.phpexplicitly registers the provider, all tests fail withClass not found.