NCL-6509: Improve XML-RPC retry handling#190
Open
dwalluck wants to merge 1 commit intorelease-engineering:masterfrom
Open
NCL-6509: Improve XML-RPC retry handling#190dwalluck wants to merge 1 commit intorelease-engineering:masterfrom
dwalluck wants to merge 1 commit intorelease-engineering:masterfrom
Conversation
Member
Author
|
It would greatly simplify the code if we could retry everything, but I am not sure. |
Extend the XML-RPC retry logic to retry on `NoHttpResponseException` in addition to `ConnectException`. Since we can't know in the case of a `NoHttpResponseException` whether the server processed the request, we check the method name to determine if it is safe to retry. We assume that API calls starting with the words get, list, query, or has are read-only and safe to retry and all others are not. Change from linear backoff to exponential backoff to give the server more time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the XML-RPC retry logic to retry on
NoHttpResponseExceptionin addition toConnectException. Since we can't know in the case of aNoHttpResponseExceptionwhether the server processed the request, we check the method name to determine if it is safe to retry. We assume that API calls starting with the words get, list, query, or has are read-only and safe to retry and all others are not.Change from linear backoff to exponential backoff to give the server more time.