Add suport for hold event in Opple WXCJKG13LM#7
Open
nununo wants to merge 2 commits into
Open
Conversation
For some reason, the `hold` event is commont to all buttons. This is reported here: Koenkk/zigbee2mqtt#25057 Fortunately, the `hold` event still provides property `button: button_X` which can be used to distinguish which button actually triggered it. This commit implements it.
Author
|
I am not 100% that this doesn't break the generic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the
holdevent is commont to all buttons. This is reported here:Koenkk/zigbee2mqtt#25057
Fortunately, the
holdevent still provides propertybutton: button_Xwhich can be used to distinguish which button actually triggered it. This commit implements it.Fixes #6.
I update the header comments and bumped the version. I'm not sure I did it right. Of course, please feel free to revise it or suggest how to.