Make ARIADNE Scenario Config Functioning Again #2227
Draft
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This is an effort to make the ARIADNE Scenario Config on the Develop Branch working again.
So far I made two major changes:
cm_emiMktTarget_tolerance: 0.003 -> GLO 0.003 (needs an additional GLO specifier now)se_tradefrom the trade realization. Withse_tradethis somehow resulted in input data problems:These two changes allow the NPi to run again. :yay:
Unfortunately:
The NPi_lowdemand still doesnt work and prompts that there is problems with the input data of the transport realization used:
What do you think is the best way forward with this? @LaviniaBaumstark @fschreyer
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)