feat(onboarding) - let users load dynamic versions of basic_information or benefits#800
Open
gabrielseco wants to merge 7 commits intomainfrom
Open
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (310 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit a04b0ad. |
Contributor
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit a04b0ad. |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some changes to let users load the basic_information json schema or benefits
Benefits currently sits on 1 version which I'll enforce it for now, this could avoid problems if platform upgrades and we cannot do it in the same rhythm
Note
Medium Risk
Updates onboarding API calls to pass configurable JSON schema version query params for
employment_basic_informationand benefit offers, which can change server-side schema selection and impact form compatibility. Risk is mitigated by defaulting to version1and adding/expanding tests around the new version resolution.Overview
Adds a new
options.jsonSchemaVersioncontract for onboarding to globally override the JSON schema versions used foremployment_basic_informationandbenefit_offers_form_schema(while keepingcontract_detailsoverrides country-specific viajsonSchemaVersionByCountry).Wires these resolved versions into onboarding API hooks (
useCreateEmployment,useUpdateEmployment, benefit offers schema fetch/update) via new helpers (getBasicInformationSchemaVersion,getBenefitOffersSchemaVersion), updates the example to demonstratelatest, and expands unit tests to assert the correct query params. Also bumps.sizelimit.jsontotalGzipthreshold to 250KB.Written by Cursor Bugbot for commit a04b0ad. This will update automatically on new commits. Configure here.