Skip to content

feat(onboarding) - let users load dynamic versions of basic_information or benefits#800

Open
gabrielseco wants to merge 7 commits intomainfrom
pbyr-3600-load-dynamically-in-the-sdk-the-basic-information-version
Open

feat(onboarding) - let users load dynamic versions of basic_information or benefits#800
gabrielseco wants to merge 7 commits intomainfrom
pbyr-3600-load-dynamically-in-the-sdk-the-basic-information-version

Conversation

@gabrielseco
Copy link
Collaborator

@gabrielseco gabrielseco commented Mar 18, 2026

I did some changes to let users load the basic_information json schema or benefits

Benefits currently sits on 1 version which I'll enforce it for now, this could avoid problems if platform upgrades and we cannot do it in the same rhythm


Note

Medium Risk
Updates onboarding API calls to pass configurable JSON schema version query params for employment_basic_information and benefit offers, which can change server-side schema selection and impact form compatibility. Risk is mitigated by defaulting to version 1 and adding/expanding tests around the new version resolution.

Overview
Adds a new options.jsonSchemaVersion contract for onboarding to globally override the JSON schema versions used for employment_basic_information and benefit_offers_form_schema (while keeping contract_details overrides country-specific via jsonSchemaVersionByCountry).

Wires these resolved versions into onboarding API hooks (useCreateEmployment, useUpdateEmployment, benefit offers schema fetch/update) via new helpers (getBasicInformationSchemaVersion, getBenefitOffersSchemaVersion), updates the example to demonstrate latest, and expands unit tests to assert the correct query params. Also bumps .sizelimit.json totalGzip threshold to 250KB.

Written by Cursor Bugbot for commit a04b0ad. This will update automatically on new commits. Configure here.

@gabrielseco gabrielseco self-assigned this Mar 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 200.06 kB 199.98 kB +81 B (+0.0%) 🔴
Total (raw) 528.81 kB 528.69 kB +122 B (+0.0%) 🔴
CSS (gzip) 19.32 kB 19.32 kB 0 B (0%) 🟢
CSS (raw) 100 kB 100 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 200.06 kB / 250 kB (80.0%)
  • ✅ Total raw: 528.81 kB / 550 kB (96.1%)
  • ✅ CSS gzipped: 19.32 kB / 25 kB (77.3%)

Largest Files (Top 5)

  1. chunk-7EONM7HL.js - 12.44 kB (0 B (0%))
  2. styles.css - 9.66 kB (0 B (0%))
  3. index.css - 9.66 kB (0 B (0%))
  4. index.js - 6.05 kB (+3 B (+0.0%))
  5. chunk-WQ4H5V7U.js - 5.77 kB (0 B (0%))
View All Files (310 total)
File Size (gzip) Change
chunk-7EONM7HL.js 12.44 kB 0 B (0%)
styles.css 9.66 kB 0 B (0%)
index.css 9.66 kB 0 B (0%)
index.js 6.05 kB +3 B (+0.0%)
chunk-WQ4H5V7U.js 5.77 kB 0 B (0%)
chunk-VT2AUDBH.js 4.24 kB new
chunk-JIW2JK7J.js 4.06 kB 0 B (0%)
chunk-NN6DQWZJ.js 3.37 kB new
chunk-I3DVKJCW.js 3.29 kB 0 B (0%)
chunk-F2WF643I.js 3.22 kB new

✅ Bundle size check passed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Deploy preview for remote-flows ready!

✅ Preview
https://remote-flows-pfi4hk4a8-remotecom.vercel.app

Built with commit a04b0ad.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-9ke07ixo9-remotecom.vercel.app

Built with commit a04b0ad.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.49% 89.48% +0.01% 🟢
Statements 89.17% 89.16% +0.01% 🟢
Functions 86.89% 86.86% +0.02% 🟢
Branches 79.40% 79.33% +0.07% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3430 / 3833
  • Coverage: 89.49%
  • Change: +0.01% (4 lines)
Statements Coverage
  • Covered: 3491 / 3915
  • Coverage: 89.17%
  • Change: +0.01% (4 statements)
Functions Coverage
  • Covered: 954 / 1098
  • Coverage: 86.89%
  • Change: +0.02% (2 functions)
Branches Coverage
  • Covered: 2143 / 2699
  • Coverage: 79.40%
  • Change: +0.07% (2 branches)

✅ Coverage check passed

@gabrielseco gabrielseco marked this pull request as ready for review March 18, 2026 12:06
@gabrielseco gabrielseco changed the title feat(onboarding) - make work happen to load dynamic versions of basic… feat(onboarding) - let users load dynamic versions of basic_information or benefits Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant