Skip to content

Force values title#801

Draft
gabrielseco wants to merge 6 commits intopbyr-3600-load-dynamically-in-the-sdk-the-basic-information-versionfrom
force-values-title
Draft

Force values title#801
gabrielseco wants to merge 6 commits intopbyr-3600-load-dynamically-in-the-sdk-the-basic-information-versionfrom
force-values-title

Conversation

@gabrielseco
Copy link
Collaborator

@gabrielseco gabrielseco commented Mar 20, 2026

I fixed two bugs here

  • one when we have a force value seniority with title, it didn't appear in the page, discovered this for KOR v3 basic information
  • the other one happened to ARG, new functionality to support / bug as they named the fieldset in x-jsf-fieldsets the same way the field wasn't appearing, this didn't happen in other schemas as they always named the thing field_fieldset...

Note

Medium Risk
Moderate risk because it changes onboarding API query parameters for schema fetch/create/update and adjusts field rendering, which could affect form behavior if version options are misconfigured; defaults remain unchanged (v1).

Overview
Onboarding flow now supports explicit JSON schema version configuration for employment_basic_information and benefit_offers_form_schema, using new helpers (getBasicInformationSchemaVersion, getBenefitOffersSchemaVersion) and wiring these versions through schema fetches and the create/update employment & benefit-offer mutations. Types and tests are expanded accordingly, and the example app demonstrates setting a basic-information schema version.

Forced-value fields now always render a title (falling back to label when no statement title is provided) and tests are updated to reflect this. Separately, flat-fieldset processing now guarantees the fieldset-flat wrapper isn’t filtered out, and the gzip bundle size limit is increased.

Written by Cursor Bugbot for commit b7b06d4. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 200 kB 199.98 kB +14 B (+0.0%) 🔴
Total (raw) 528.77 kB 528.69 kB +80 B (+0.0%) 🔴
CSS (gzip) 19.32 kB 19.32 kB 0 B (0%) 🟢
CSS (raw) 100 kB 100 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 200 kB / 250 kB (80.0%)
  • ✅ Total raw: 528.77 kB / 550 kB (96.1%)
  • ✅ CSS gzipped: 19.32 kB / 25 kB (77.3%)

Largest Files (Top 5)

  1. chunk-7EONM7HL.js - 12.44 kB (0 B (0%))
  2. styles.css - 9.66 kB (0 B (0%))
  3. index.css - 9.66 kB (0 B (0%))
  4. index.js - 6.05 kB (+3 B (+0.0%))
  5. chunk-WQ4H5V7U.js - 5.77 kB (0 B (0%))
View All Files (310 total)
File Size (gzip) Change
chunk-7EONM7HL.js 12.44 kB 0 B (0%)
styles.css 9.66 kB 0 B (0%)
index.css 9.66 kB 0 B (0%)
index.js 6.05 kB +3 B (+0.0%)
chunk-WQ4H5V7U.js 5.77 kB 0 B (0%)
chunk-GRE4RCPB.js 4.24 kB new
chunk-JIW2JK7J.js 4.06 kB 0 B (0%)
chunk-D4TLSPX5.js 3.37 kB new
chunk-JEGVULKU.js 3.3 kB new
chunk-KEFIHTZ2.js 3.21 kB new

✅ Bundle size check passed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-8yw40flvw-remotecom.vercel.app

Built with commit e2b7774.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Deploy preview for remote-flows ready!

✅ Preview
https://remote-flows-cf9baghse-remotecom.vercel.app

Built with commit e2b7774.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.49% 89.48% +0.02% 🟢
Statements 89.18% 89.16% +0.02% 🟢
Functions 86.89% 86.86% +0.02% 🟢
Branches 79.40% 79.33% +0.07% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3433 / 3836
  • Coverage: 89.49%
  • Change: +0.02% (7 lines)
Statements Coverage
  • Covered: 3494 / 3918
  • Coverage: 89.18%
  • Change: +0.02% (7 statements)
Functions Coverage
  • Covered: 954 / 1098
  • Coverage: 86.89%
  • Change: +0.02% (2 functions)
Branches Coverage
  • Covered: 2143 / 2699
  • Coverage: 79.40%
  • Change: +0.07% (2 branches)

✅ Coverage check passed

@gabrielseco
Copy link
Collaborator Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@gabrielseco gabrielseco changed the base branch from main to pbyr-3600-load-dynamically-in-the-sdk-the-basic-information-version March 20, 2026 11:06
@gabrielseco gabrielseco self-assigned this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant