Skip to content

added check against nhs data spline#15

Open
philmain28 wants to merge 2 commits into
mainfrom
rr1_plus_checks
Open

added check against nhs data spline#15
philmain28 wants to merge 2 commits into
mainfrom
rr1_plus_checks

Conversation

@philmain28
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread tests/test_rr1.py
BASE_URL = "https://uat.directory.spineservices.nhs.uk/ORD/2-0-0/organisations/"
errors = {}

with open('tables/code_list/rr1plus_facilities.csv', newline='') as csvfile:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RR1 / RR1+ Codes are issued by the UKRR and so won't match to ODS.

We need an RR1 / RR1+ to ODS mapping, and then we can do such checks. Also some sites are already sending in Coding Standard ODS locations. There are a few further cans of worms with this though.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the source of truth for the RR1+ codes then?

this?
https://github.com/renalreg/resources/blob/master/dataset/UKRR/v4/UKRR%20DataSet%20v4_2_0.xls

In the various tables there is all sorts of junk for example I think phosphate is mapped as an RR1+ code.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( https://renalregistry.atlassian.net/wiki/spaces/SGTTUKKA/pages/2521366888/RR1+Codes )

We have the RR1 list of "Main Units". This is listed in the UKRR dataset and changes very rarely. This is maintained by the UKRR and does not follow NHS Organisational Structure, not patient care. A large criteria for being a main unit has been operating a renal system.

We then have RR1+ which is RR1 "plus" the satellites. Someone before my time (which takes it back a lot) imported a picklist of all the NHS sites into the RR_CODES table irrespective of whether they did renal care.

When new codes have been required these have been created, basically by me picking one at random. Lately (post-2015 since we started using ODS for AKI Labs) we've tried to use ODS codes but some sites don't engage with ODS and we can't request them on their behalf. There is also some confusion about what ODS code should be used where a satellite dialysis unit is run by Hospital A but on the premises of Hospital B. Same with private dialysis Units.

We need to sort this out as the codes confuse the NHS when we share data, especially when our codes coincidentally match an NHS location - but with different meaning. That reminds me that I should add that where a dialysis unit or somesuch moves location it is common that a renal unit won't bother to register a new code and update the renal system, they'll just consider the old code has changed.

Act! is probably the most categorial source of information but needs improvement.

There are also some tickets...

https://renalregistry.atlassian.net/browse/RR-992
https://renalregistry.atlassian.net/browse/RR-1002

About this, possibly more, but you may guess why we lost impetus.

As for PHOSPHATE being in the "RR1+" list we need to change it so that SendingFacility is validated against the Facility table, not CODE_LIST/RR1+. It's on my TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants