Validation for the facility codes#57
Open
philmain28 wants to merge 5 commits into
Open
Conversation
Collaborator
|
I think this is worth merging but the bit about checking the names to ODS codes needs changing to a "for info" rather than something that will fail the build as there's going to be lots of differences - some of which will be correct due to how UKRR are using the codes. |
Collaborator
Author
|
I think the descriptions on the NHS list isn't especially more consistent than ours. Thats without thinking about things like collisions. |
Collaborator
|
Not sure I understand. By "some of which will be correct due to how UKRR are using the codes." - I meant "some of the differences in name are because the UKRR are using a code which matches an ODS code but to describe something different". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some validation checks to the facilities: