Skip to content

Validation for the facility codes#57

Open
philmain28 wants to merge 5 commits into
mainfrom
facility_test
Open

Validation for the facility codes#57
philmain28 wants to merge 5 commits into
mainfrom
facility_test

Conversation

@philmain28
Copy link
Copy Markdown
Collaborator

@philmain28 philmain28 commented Feb 11, 2026

Added some validation checks to the facilities:

  • check that facilities in the facility table are in the code_map tables
  • check that satellites and main units have the same first data quarter, startdate, enddate
  • check that units sharing feeds ""

@philmain28 philmain28 changed the title added tests for places Validation for the facility codes Feb 11, 2026
@George-D-S George-D-S self-requested a review May 20, 2026 12:39
@George-D-S
Copy link
Copy Markdown
Collaborator

I think this is worth merging but the bit about checking the names to ODS codes needs changing to a "for info" rather than something that will fail the build as there's going to be lots of differences - some of which will be correct due to how UKRR are using the codes.

@philmain28
Copy link
Copy Markdown
Collaborator Author

I think the descriptions on the NHS list isn't especially more consistent than ours. Thats without thinking about things like collisions.

@George-D-S
Copy link
Copy Markdown
Collaborator

Not sure I understand.

By "some of which will be correct due to how UKRR are using the codes." - I meant "some of the differences in name are because the UKRR are using a code which matches an ODS code but to describe something different".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants