[codex] Add in-memory keystore flag#160
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds an opt-in
--keystore-in-memoryflag for hardened validator deployments. When set, the node overrides the generated service configuration to use Substrate's existingKeystoreConfig::InMemory, so session keys are not loaded from or written to an on-disk keystore path.Details
--keystore-in-memoryCLI flag.--keystore-path, password flags,--dev, and development key shortcuts.service::new_fullconstructs the node service.Validation
cargo fmt --checkgit diff --checkWASM_BUILD_WORKSPACE_HINT=/Users/janzimolka/workspace/torus-substrate cargo test --target-dir /private/tmp/torus-target-issue155 -p torus-node keystore --lockedWASM_BUILD_WORKSPACE_HINT=/Users/janzimolka/workspace/torus-substrate cargo clippy --target-dir /private/tmp/torus-target-issue155 -p torus-node --locked --all-targets -- -D warningstorus-nodeand smoke-tested a fresh base path; nokeystore/directory was created before the sandbox blocked network socket binding.Closes #155.