Skip to content

Fix caption token casing not working with punctuation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix caption token casing not working with punctuation #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,10 @@ def blip_captioning_dataset(
)
caption = processor.decode(out[0], skip_special_tokens=True)

# BLIP 2 lowercases all caps tokens. This should properly replace them w/o messing up subwords. I'm sure there's a better way to do this.
# BLIP 2 lowercases all caps tokens, so do a quick find and replace
for token in substitution_tokens:
print(token)
sub_cap = " " + caption + " "
print(sub_cap)
sub_cap = sub_cap.replace(" " + token.lower() + " ", " " + token + " ")
caption = sub_cap.strip()
pattern = r"\b" + re.escape(token.lower()) + r"\b"
caption = re.sub(pattern, token, caption)

captions.append(caption)
print("Generated captions", captions)
Expand Down