node: add iter_cell_size and iter_prop_encoded helpers#31
Open
rmsyn wants to merge 4 commits intorepnop:masterfrom
Open
node: add iter_cell_size and iter_prop_encoded helpers#31rmsyn wants to merge 4 commits intorepnop:masterfrom
iter_cell_size and iter_prop_encoded helpers#31rmsyn wants to merge 4 commits intorepnop:masterfrom
Conversation
repnop
requested changes
May 2, 2024
Owner
repnop
left a comment
repnop
left a comment
There was a problem hiding this comment.
Some light changes and considerations
rmsyn
force-pushed
the
node/prop-usize-list
branch
from
66686aa to
3da12f1
Compare
Adds a `NodeProperty::as_usize_list` helper function to parse the property value as a `usize` list.
Adds the `CellSize` enum type to represent valid property value cell size variants.
rmsyn
force-pushed
the
node/prop-usize-list
branch
from
3da12f1 to
49ba36c
Compare
Converts the `CellSizes` type to use the new `CellSize` type instead of `usize`.
Adds a helper function `FdtNode::iter_prop_encoded` to parse a property as a `prop-encoded-array`.
rmsyn
force-pushed
the
node/prop-usize-list
branch
from
49ba36c to
c7f7bc9
Compare
Contributor
Author
|
@repnop I added some changes to address the points you brought up. I removed the I also added the |
rmsyn
changed the title
as_usize_list helperiter_cell_size and iter_prop_encoded helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
NodeProperty::as_usize_listhelper function to parse the property value as ausizelist.