-
Notifications
You must be signed in to change notification settings - Fork 29
Release #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support for formatting test item names as templates using provided parameters and exposes template engine configuration through the Launch API.
Changes:
- Format
StartTestItemRQ.nameusingStartTestItemRQ.parameters(including indexed placeholders like{0}) and add a test covering this behavior. - Expose
TemplateConfigurationviaLaunch#getTemplateConfiguration()and wire it intoLaunchImpl. - Preserve attribute parsing order by switching
AttributeParsertoLinkedHashSet, and simplify OkHttp timeout wiring viaDurationoverloads.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/epam/reportportal/service/LaunchTest.java | Adds parameterized tests validating item name templating behavior. |
| src/main/java/com/epam/reportportal/utils/AttributeParser.java | Uses LinkedHashSet to preserve insertion order for parsed attributes. |
| src/main/java/com/epam/reportportal/service/OAuth2PasswordGrantAuthInterceptor.java | Uses OkHttp Duration overloads for timeouts (cleanup). |
| src/main/java/com/epam/reportportal/service/LaunchImpl.java | Implements name templating, adds template config storage, refactors request modification logic. |
| src/main/java/com/epam/reportportal/service/Launch.java | Adds a template configuration accessor to the public Launch API (and NOOP implementation). |
| CHANGELOG.md | Documents the new item name formatting feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.