Skip to content

Fix keras error - #8

Open
jsrozner wants to merge 1 commit into
repp:masterfrom
jsrozner:patch-1
Open

jsrozner wants to merge 1 commit into
repp:masterfrom
jsrozner:patch-1

Conversation

@jsrozner

@jsrozner jsrozner commented Mar 7, 2021

Copy link
Copy Markdown

Change initialization from None to max_seq_len

Tested, works!

Change initialization from None to max_seq_len

Tested, works!
@jsrozner

jsrozner commented Mar 7, 2021

Copy link
Copy Markdown
Author

fixes #4

@StuartIanNaylor

StuartIanNaylor commented May 29, 2022

Copy link
Copy Markdown

Yeah I tested and works, thnx @jsrozner

PS pip works not sure what happens with the git clone method as looks for a module called google.prorobuf which is installed but is protobuf

@jsrozner suppose you didn't figure a way to group phones by syllable, did you? :)

@jsrozner

jsrozner commented Jun 3, 2022

Copy link
Copy Markdown
Author

You should accept the pull request :)

PS pip works not sure what happens with the git clone method as looks for a module called google.prorobuf which is installed but is protobuf

@jsrozner suppose you didn't figure a way to group phones by syllable, did you? :)

Hmm - I don't remember much about either of these discussions? Was I trying to group phonemes by syllable before?

@StuartIanNaylor

Copy link
Copy Markdown

:) thanks as that would be a super addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants