Skip to content

Do not include alloca.h on OpenBSD#3

Merged
res2k merged 1 commit intomainfrom
unknown repository
May 19, 2025
Merged

Do not include alloca.h on OpenBSD#3
res2k merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 19, 2025

A define is needed to prevent including alloca.h on OpenBSD, which lacks this header file. Without this q2repro fails to build.

A define is needed to prevent including alloca.h on OpenBSD, which lacks this header file. Without this q2repro fails to build.
@res2k res2k merged commit 73f8bd8 into res2k:main May 19, 2025
7 of 8 checks passed
@res2k
Copy link
Copy Markdown
Owner

res2k commented May 19, 2025

Thanks!
If you're comfortable enough with GitHub workflows I'd happily accept an addition of OpenBSD to the build workflow.
This can help with avoiding future changes breaking on OpenBSD.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 20, 2025

Great, I've just done this: #4. The workflow runs and it's the same that I use to build it on a desktop system (with graphics etc.).

Meanwhile there's a similar PR for the game DLL that I've submitted here: Paril/quake2-rerelease-dll#1. In combination with this change, Q2RePro builds out of the box on both FreeBSD and OpenBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant