Also guard against arrays falling into object branch in untagged vari…#8255
Merged
cristianoc merged 1 commit intomasterfrom Feb 25, 2026
Merged
Also guard against arrays falling into object branch in untagged vari…#8255cristianoc merged 1 commit intomasterfrom
cristianoc merged 1 commit intomasterfrom
Conversation
…ant switch (#8251) Arrays also have typeof "object", so when there's an ObjectType typeof case but no Array instanceof case, arrays would incorrectly match the object branch. Add an Array.isArray guard alongside the null guard. Also clean up the guard logic to use direct pattern matching instead of intermediate list building. Signed-Off-By: Cristiano Calcagno <cristiano.calcagno@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nojaf
approved these changes
Feb 25, 2026
Member
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Test output looks good!
Code as well, but not really familiar with that part of the compiler.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ant switch (#8251)
Arrays also have typeof "object", so when there's an ObjectType typeof case but no Array instanceof case, arrays would incorrectly match the object branch. Add an Array.isArray guard alongside the null guard.
Also clean up the guard logic to use direct pattern matching instead of intermediate list building.