Skip to content

feat(domains): add TrackingCAA record support#100

Merged
drish merged 1 commit into
mainfrom
feat/tracking-caa-record
Apr 15, 2026
Merged

feat(domains): add TrackingCAA record support#100
drish merged 1 commit into
mainfrom
feat/tracking-caa-record

Conversation

@rehanvdm

@rehanvdm rehanvdm commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The Domains API now returns an additional DNS record on POST /domains and GET /domains/:id responses when:

  1. A tracking_subdomain is configured on the domain, AND
  2. The customer's root domain has CAA records that would otherwise prevent AWS from issuing a TLS certificate.

The new record looks like:

{
  "record": "TrackingCAA",
  "name": "",
  "type": "CAA",
  "ttl": "Auto",
  "value": "0 issue \"amazon.com\"",
  "status": "verified"
}

DomainRecord.Record is already a free-form string so no source change is required for deserialization. This PR:

  • Updates the xmldoc remark on DomainRecord.Record to list TrackingCAA as a possible value.
  • Adds a Domain_deserializes_tracking_caa_record test that exercises both Tracking and TrackingCAA records end-to-end.

Test plan

  • New unit test deserializes a domain payload containing both Tracking and TrackingCAA records and asserts every field
  • CI runs full test suite

Summary by cubic

Add support for the TrackingCAA DNS record in Domains API responses when a tracking subdomain is set and existing CAA records would block AWS certificate issuance. No runtime changes needed; updated DomainRecord.Record remarks to include TrackingCAA and added a unit test that deserializes both Tracking and TrackingCAA records.

Written for commit f058726. Summary will update on new commits.

The Domains API now returns an additional `TrackingCAA` DNS record on
create/get responses when a tracking subdomain is configured AND the
customer's root domain has CAA records that would block AWS from
issuing a certificate.

`DomainRecord.Record` is already a free-form string so the new value
deserializes without a code change. Update the xmldoc remark to list
`TrackingCAA` as a possible value, and add a deserialization test that
covers the new record alongside the existing Tracking record.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@drish drish self-requested a review April 15, 2026 15:17
@drish drish merged commit 8167128 into main Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants