chore(ci): harden security#115
Merged
gabrielmfern merged 1 commit intoMay 13, 2026
Merged
Conversation
Signed-off-by: gabriel miranda <gabrielmfern@outlook.com>
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: DEV-655: [resend-dotnet] GH Actions hardening — 1 HIGH / 2 MED / 2 LOW
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Use a hashFiles-based cache key for the NuGet cache to prevent cache poisoning (both CI and release workflows). | Both .github/workflows/ci.yml and .github/workflows/release.yml replace the fixed key with nuget-${{ hashFiles('**/*.csproj','**/packages.lock.json') }}, addressing the cache-poisoning finding. |
| ✅ | Declare appropriate top-level permissions for workflows (CI workflow was missing permissions). | ci.yml adds permissions: contents: read; release.yml already had permissions: contents: write, so workflows now declare top-level permissions. |
| ✅ | Add a concurrency group for release.yml to avoid concurrent release runs. | release.yml now includes a concurrency block with group: ${{ github.workflow }}-${{ github.ref }} and cancel-in-progress: false. |
| ✅ | Add timeout-minutes to jobs that were missing timeouts (two jobs). | Both build jobs in ci.yml and release.yml now include timeout-minutes: 30. |
Auto-approved: These changes harden CI/CD security by pinning actions to specific SHAs, adding granular permissions, timeouts, and release concurrency, with no impact on application logic or data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Hardened GitHub Actions for
resend-dotnetby pinning actions, scoping NuGet cache keys, and adding least-privilege permissions, timeouts, and release concurrency. Addresses Linear DEV-655.actions/checkout,actions/setup-dotnet, andactions/cacheto SHAs.key: nuget-${{ hashFiles('**/*.csproj','**/packages.lock.json') }}andpath: .nuget.permissions: contents: readat the CI workflow level; keptcontents: writefor release.timeout-minutes: 30to CI and Release jobs andconcurrencyfor Release to prevent parallel publishes.Written for commit e492c50. Summary will update on new commits.