Add missing fields#122
Open
adv76 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- There is a concrete regression risk in
src/Resend/EmailStatus.cs: addingSentin the middle ofEmailStatusreindexes later enum values, which can change serialized/stored values seen by existing consumers. - This is moderate risk (severity 6/10, confidence 8/10) because behavior can break at integration boundaries even if local compilation/tests pass.
- Pay close attention to
src/Resend/EmailStatus.cs- enum numeric value shifts may break compatibility forSuppressed/Failedconsumers unless explicit values are assigned.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/Resend/EmailStatus.cs">
<violation number="1" location="src/Resend/EmailStatus.cs:77">
P2: Inserting the new `Sent` enum member in the middle of `EmailStatus` changes the underlying integer values of existing members (`Suppressed`, `Failed`) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| /// <summary> | ||
| /// Email has been sent. | ||
| /// </summary> | ||
| [JsonStringValue( "sent" )] |
There was a problem hiding this comment.
P2: Inserting the new Sent enum member in the middle of EmailStatus changes the underlying integer values of existing members (Suppressed, Failed) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/Resend/EmailStatus.cs, line 77:
<comment>Inserting the new `Sent` enum member in the middle of `EmailStatus` changes the underlying integer values of existing members (`Suppressed`, `Failed`) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.</comment>
<file context>
@@ -71,6 +71,12 @@ public enum EmailStatus
+ /// <summary>
+ /// Email has been sent.
+ /// </summary>
+ [JsonStringValue( "sent" )]
+ Sent,
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing Email Status "Sent" and missing "Tags" field to Email Receipt.
Summary by cubic
Add the missing EmailStatus "sent" and the "tags" field on EmailReceipt to align with the Resend API. This enables clients to read tag metadata and the sent status from receipts.
Written for commit 82d10e4. Summary will update on new commits.