Skip to content

Add missing fields#122

Open
adv76 wants to merge 2 commits into
resend:mainfrom
adv76:add-missing-fields
Open

Add missing fields#122
adv76 wants to merge 2 commits into
resend:mainfrom
adv76:add-missing-fields

Conversation

@adv76

@adv76 adv76 commented May 30, 2026

Copy link
Copy Markdown
Contributor

Add missing Email Status "Sent" and missing "Tags" field to Email Receipt.


Summary by cubic

Add the missing EmailStatus "sent" and the "tags" field on EmailReceipt to align with the Resend API. This enables clients to read tag metadata and the sent status from receipts.

  • New Features
    • Added EmailStatus.Sent mapped to JSON value "sent".
    • Added EmailReceipt.Tags: List? serialized as "tags".

Written for commit 82d10e4. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Confidence score: 3/5

  • There is a concrete regression risk in src/Resend/EmailStatus.cs: adding Sent in the middle of EmailStatus reindexes later enum values, which can change serialized/stored values seen by existing consumers.
  • This is moderate risk (severity 6/10, confidence 8/10) because behavior can break at integration boundaries even if local compilation/tests pass.
  • Pay close attention to src/Resend/EmailStatus.cs - enum numeric value shifts may break compatibility for Suppressed/Failed consumers unless explicit values are assigned.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/Resend/EmailStatus.cs">

<violation number="1" location="src/Resend/EmailStatus.cs:77">
P2: Inserting the new `Sent` enum member in the middle of `EmailStatus` changes the underlying integer values of existing members (`Suppressed`, `Failed`) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/Resend/EmailStatus.cs
/// <summary>
/// Email has been sent.
/// </summary>
[JsonStringValue( "sent" )]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Inserting the new Sent enum member in the middle of EmailStatus changes the underlying integer values of existing members (Suppressed, Failed) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/Resend/EmailStatus.cs, line 77:

<comment>Inserting the new `Sent` enum member in the middle of `EmailStatus` changes the underlying integer values of existing members (`Suppressed`, `Failed`) because no explicit values are assigned. This can break consumers that rely on numeric casts, database storage, or ordinal positions.</comment>

<file context>
@@ -71,6 +71,12 @@ public enum EmailStatus
+    /// <summary>
+    /// Email has been sent.
+    /// </summary>
+    [JsonStringValue( "sent" )]
+    Sent,
+
</file context>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant