feat: allow CNAME type on domain SPF records - #1085
Merged
Merged
Conversation
commit: |
klotty
approved these changes
Aug 27, 2026
klotty
left a comment
klotty
left a comment
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Type widening on DomainSpfRecord to include 'CNAME', reflecting actual API return values; no behavioral, operational, or security tradeoff, just a type correction.
Re-trigger cubic
Member
|
we got to make sure this is also right in the docs, open api spec, and all of the other sdks |
gabrielmfern
approved these changes
Aug 27, 2026
Member
|
you rock! |
Amp-Thread-ID: https://ampcode.com/threads/T-01a04537-de81-73ba-b5dd-982f0e54b8b1 Co-authored-by: Gabriel Miranda <gabriel@resend.com>
klotty
approved these changes
Aug 27, 2026
klotty
left a comment
klotty
left a comment
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Type-only widening of DomainSpfRecord.type to include 'CNAME' to match actual API output, plus a version bump; no behavioral, operational, security, or data tradeoff.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DomainSpfRecord.typewas typed'MX' | 'TXT', but the API can return an SPF record withtype: 'CNAME'for domains on Resend's internal MTA (the return-path is a managed CNAME instead of the classic MX+TXT pair). This widens the type to include'CNAME'so those records type-check correctly.Note: this is a type widening on an output union, so consumers doing exhaustive
switch/assertNeveron an SPF record'stypewill get a compile nudge to handle theCNAMEcase — which is the intended outcome, since the API can already return it.Summary by cubic
Widens
DomainSpfRecord.typeto include'CNAME'because the API returns that value for domains on Resend's internal MTA (the return-path is a managed CNAME instead of the classic MX+TXT pair), and bumps the package version to 6.25.0. This is a type widening on an output union, so consumers doing exhaustiveswitch/assertNeveron an SPF record'stypewill get a compile nudge to handle theCNAMEcase — which is the intended outcome.Written for commit 2c2e315. Summary will update on new commits.