feat: add configurable timeout for backendEndpoint calls#55
Open
Vaishnav88sk wants to merge 1 commit intoreshaprio:mainfrom
Open
feat: add configurable timeout for backendEndpoint calls#55Vaishnav88sk wants to merge 1 commit intoreshaprio:mainfrom
Vaishnav88sk wants to merge 1 commit intoreshaprio:mainfrom
Conversation
lbroudoux
requested changes
Apr 7, 2026
Member
lbroudoux
left a comment
lbroudoux
left a comment
There was a problem hiding this comment.
Thanks for taking the time to push this! Some changes to address.
control-plane/src/main/resources/db/migration/V1.0.0__inception.sql
Outdated
Show resolved
Hide resolved
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com> feat: add configurable timeout for backendEndpoint calls Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Vaishnav88sk
force-pushed
the
vaishnav-reshapr
branch
from
f5dabc0 to
703a232
Compare
Author
|
I've addressed the requested changes and pushed the latest updates. Please let me know if any further changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Add a
backendEndpointTimeoutfield (ms) toConfigurationPlan. When importing an API,set it via the control plane API. Defaults to 3000ms if not set. Proxy now returns
HTTP 504 instead of hanging indefinitely when the backend does not respond in time.
Tested via
ProxyServiceTest- all 3 tests pass.