correct error in valid_gpu()#15
Open
annlor wants to merge 1 commit intoresponsibleproblemsolving:masterfrom
Open
correct error in valid_gpu()#15annlor wants to merge 1 commit intoresponsibleproblemsolving:masterfrom
annlor wants to merge 1 commit intoresponsibleproblemsolving:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As indicated in Issue #14, there is an issue with the valid_gpu() function. subprocess.check_call() returns an integer (return code) and not a float as tested. This results in valid_gpu() always returning False. Fixing this error triggers an error "'RAPLFile' object is not callable" when creating RAPL files with GPU logs. I removed this section.
I had trouble importing the module so I also changed the imports syntax.