Fix npm OIDC publish: restore registry-url and clear NODE_AUTH_TOKEN in publish steps#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #95 which went too far.
registry-urlinsetup-node(required: this is what creates the.npmrcthat enables npm's OIDC token exchange; without it, npm has no auth config at all ->ENEEDAUTH)setup-nodewithregistry-urlautomatically exportsNODE_AUTH_TOKEN=$GITHUB_TOKENfor subsequent steps; npm sees a non-empty token and uses it instead of OIDC, causing 404NODE_AUTH_TOKEN: ""in both publish steps so npm sees an empty token and falls through to OIDC trusted publishing exchangeNo
NPM_TOKENsecret needed once this lands.Test plan
NPM_TOKEN