Fix OIDC publish: use Node 24 bundled npm, drop --provenance and corepack install#99
Merged
Conversation
pcholakov
force-pushed
the
drop-provenance
branch
3 times, most recently
from
b9c0fbc to
857a70b
Compare
pcholakov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified working -- triggered the workflow on this branch via workflow_dispatch and a snapshot was published successfully (with provenance auto-attached) to npm via OIDC trusted publishing, no NPM_TOKEN. See run https://github.com/restatedev/cdk/actions/runs/25457317247.
The actual root cause: the
corepack install -g npm@lateststep installs npm 11.14, which fails OIDC trusted publishing with ENEEDAUTH instead of falling through to the OIDC token exchange. Node 24's bundled npm 10.x (matching what byoc uses) works correctly.Changes:
--provenancefrom publish commands (npm auto-attaches provenance via OIDC trusted publishing; this flag is redundant)Test plan