Skip to content

Issue161 add exception conversion#974

Closed
boillodmanuel wants to merge 9 commits intomasterfrom
issue161-add-exception-conversion
Closed

Issue161 add exception conversion#974
boillodmanuel wants to merge 9 commits intomasterfrom
issue161-add-exception-conversion

Conversation

@boillodmanuel
Copy link
Copy Markdown
Contributor

@boillodmanuel boillodmanuel commented Oct 30, 2014

PR for issue #161

Moved from PR 969. See this for history

Manuel Boillod and others added 7 commits October 30, 2014 18:41
Add exception conversion to ConverterService- Issue #161
3e906ba 
Add content negotiation in StatusFilter
Remove code which is already done in StatusFilter.java
bee8ca8
Extract BeanInfoutils from ThrowableSerializer
4dfe3ce
Use StatusRepresentation instead of a map (better for documentation)
40783be
Verify response entity in tests
550465f
Fix GWT Edition
195307b 
WARNING: StatusService has been removed from GWT Edition
- Added connegService, metadataService and converterService properti…
a54fa8a 
…es to StatusService and pass them via the constructor instead of the toRepresentation and toStatus methods.

 - Renamed @Status#serializeProperties (default to false) into serialize (default to true).
 - Deprecated Component#statusService in favor of the Application#statusService property.
@jlouvel jlouvel added this to the 2.3 M4 milestone Oct 31, 2014
@jlouvel
Copy link
Copy Markdown
Collaborator

jlouvel commented Oct 31, 2014

Just pushed those refactorings/changes:

  • Added connegService, metadataService and converterService properties to StatusService and pass them via the constructor instead of the toRepresentation and toStatus methods.
  • Renamed @Status#serializeProperties (default to false) into serialize (default to true).
  • Deprecated Component#statusService in favor of the Application#statusService property.

Assigned to @boillodmanuel Could you check the code and merge it into 2.3 M4 with @thboileau help?

@jlouvel
Copy link
Copy Markdown
Collaborator

jlouvel commented Oct 31, 2014

There is an issue with testSerializedException() in StatusServiceTestCase that needs to be fixed.

thboileau and others added 2 commits October 31, 2014 14:23
@thboileau
Updated comments.
9cd28a5
issue #161
3aaa245 
- fix compatibility issue with version 2.2
- rename `StatusRepresentation` to `StatusInfo`
- restore `StatusService` in GWT edition
@boillodmanuel
Copy link
Copy Markdown
Contributor Author

boillodmanuel commented Oct 31, 2014

Last changes:

  • fix compatibility issue with version 2.2
  • rename StatusRepresentation to StatusInfo
  • restore StatusService in GWT edition

thboileau added a commit that referenced this pull request Oct 31, 2014
@thboileau
Merged pull request #974.
5701f7d
@boillodmanuel
Copy link
Copy Markdown
Contributor Author

boillodmanuel commented Oct 31, 2014

Merged manually

@thboileau thboileau deleted the issue161-add-exception-conversion branch November 27, 2014 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@boillodmanuel boillodmanuel

Labels

Module: Restlet API

Projects

None yet

Milestone

2.3 M4

Development

Successfully merging this pull request may close these issues.

3 participants

@boillodmanuel @jlouvel @thboileau