Skip gemdrive initialization by holding down a modifier key (shift, ctrl or alt)#99
Open
tin-nl wants to merge 5 commits intoretro16:stablefrom
Open
Skip gemdrive initialization by holding down a modifier key (shift, ctrl or alt)#99tin-nl wants to merge 5 commits intoretro16:stablefrom
tin-nl wants to merge 5 commits intoretro16:stablefrom
Conversation
Author
|
(sorry, my base branch was 5.1, somehow GitHub missed that and assumed "stable" plus I did not correct that when creating this - let me know if I should send a new pull request) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of #75 and the long-standing practice of TOS hard disk drivers being skippable by pressing modifier key(s) (e.g. HDDRIVER, ICD or CE_DD) I added such a skip option.
I know It's possible to flash a specific firmware or set jumpers accordingly, but having a way to skip a driver is good practice IMHO in any case. I am aware that driver space is precious in this case, but #94 makes me pretty hopeful that there's space to be found (although I have not managed to remove the USB lib myself yet - but I don't know the first thing about Arduino and it' libs/link process).
Having said that: I really love the work you've done here, so I hope you don't mind my nitpicking - and tbf w/o #75 I probably wouldn't have missed that feature anyways.