Skip to content

Improve SFTP Auth#315

Open
jasonzli-DEV wants to merge 6 commits into
reviactyl:developfrom
jasonzli-DEV:fix/improve-sftp-security
Open

Improve SFTP Auth#315
jasonzli-DEV wants to merge 6 commits into
reviactyl:developfrom
jasonzli-DEV:fix/improve-sftp-security

Conversation

@jasonzli-DEV

Copy link
Copy Markdown
Member

This commit improves the SFTP auth flow. It does not patch a vulnerability, but makes it safer and provides some quality of life improvements.

  • All failures respond with the same error
  • Rate limits are based on IP and username instead of just the username string.
  • Rate limits reset after successful auth
  • Permission failures are treated as auth failures
  • Centralized Logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants