feat(diagnostics): show bridge rate cap next to wire Hz - #11
Merged
Conversation
Reads the max_hz column from ROS2DiagnosticsInfo and renders the Hz cell as wire rate plus a weak '(capped N)' annotation. Old recordings without the column render unchanged. Extras pin moves to the feature branch temporarily and flips to the v0.7.0 tag at release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the bridge throttles a topic, the
Diagnosticspanel keeps showing the wire rate while the plot updates at the cap, which reads as data loss. This renders the cap next to the wire rate so the state explains itself.Changes
src/views/diagnostics/system.rsqueries the new optionalmax_hzcolumn fromROS2DiagnosticsInfoand parses it likelatency_ms(empty string means unthrottled).src/views/diagnostics/mod.rsrenders the wire rate with a weak(capped N)annotation when a cap is present. Unthrottled topics and old recordings render exactly as before.feature/rew-200branch temporarily and flips to thev0.7.0tag at release.Sorting still uses the wire rate, so the column ordering is unchanged by throttling.
Related
Checklist
cargo fmt --checkis cleancargo clippy --all-targets -- -D warningsis clean (native)cargo testpasses///docsBreaking changes
None. The new component is optional in both directions, old recordings and old bridges render without the annotation.