ci: use the shared build-wasm action - #21
Merged
Merged
Conversation
Replaces the wasm-bindgen chain in both wasm jobs with rewire-run/actions/build-wasm@v1, and migrates the release job's toolchain and cache to setup-rust while it is being touched. The two copies had already drifted: ci installed no binaryen and never optimized, release did both. That difference is now the optimize input rather than two separately maintained step lists. Behaviour is unchanged. Same wasm-bindgen 0.2.117, same binaryen version_130, same --no-default-features, same web/ output directory, and the release job keeps its release profile and wasm-opt -Oz pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the wasm-bindgen chain in both wasm jobs with
rewire-run/actions/build-wasm@v1, and moves the release job's toolchain and cache tosetup-rustwhile it is being touched. The ci and release copies had drifted on binaryen andwasm-opt, which is now theoptimizeinput.