Conversation
Owner
|
Hey man, many thanks for the updates. I haven't spent much time with this module, as I've moved away from boxen and puppet for laptop provisioning. Can you rebase to squash these changes into one or two significant commits? Once you do that, I will definitely accept. Thanks again! |
Not necessary as the content comes from the unzip proper order proper destDir values unzip package needed jre is also needed mysql jar updated to the latest available version The test must check for directory not for file To test proper regsubst More test Another test Another test typo regexp expression fixed flag not necessary to keep pentaho products on the same folder Proper variable declaration to allow hiera interpolation Some flags to check proper URL Last available version at this moment Basic installation.
Author
|
Hi, I have squashed it, but I am not really good at it. Have a look. Best regards |
lint errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have re-factored the module and made it work.
It has been tested on Debian 8.1
Best regards