feat(factory): First Pass on Quickstart Factory Skills for Green Field#1
feat(factory): First Pass on Quickstart Factory Skills for Green Field#1johnson2500 wants to merge 2 commits into
Conversation
| ### Create repository | ||
|
|
||
| ```bash | ||
| gh repo create rh-ai-quickstart/<slug> --public --description "<from PRD>" --clone |
There was a problem hiding this comment.
I think that the default state should be:
1. Open a new rh-ai-quickstart/ repo - with an empty readme & license
2. Fork it under your user.
3. Work on the fork.
There was a problem hiding this comment.
While running this skill, the a yml file was generated with the following lines:
pgvector:
image: pgvector/pgvector:pg16
ports:
- "5432:5432"
environment:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
POSTGRES_DB: semantic_router
volumes:
- pgvector-data:/var/lib/postgresql/data
For POSTGRES_PASSWORD:
- The user should be able to set the value or be aware that we are using generic passwords.
- Either way, it's better if we include the passwords under the
.envfile and create secrets later when deploying
There was a problem hiding this comment.
Two comments about this stage:
- The repo was cloned under
/tmpdirectory by default, which probably happened during the scaffolding. - Since most of the code of the app is being written at this stage, I'd add a recommendation for the user to open their IDE.
There was a problem hiding this comment.
I wasn't sure where to put the source code. We could also have this in the data/ directory like the other artifacts.
There was a problem hiding this comment.
rh-qs-scaffold created pyproject.toml files. When running the implementation skill, it does not use uv for package management and Python virtual environment (.venv)
cd /tmp/vllm-semantic-router/packages/api && pip install -e ".[test]" -q 2>&1 | tail -5)
⎿ (eval):1: command not found: pip
cd /tmp/vllm-semantic-router/packages/api && pip3 install -e ".[test]" -q 2>&1 | tail -5
cd /tmp/vllm-semantic-router/packages/api && python3 -m venv .venv && .venv/bin/pip install -e ".[test]" -q 2>&1 | tail -3
There was a problem hiding this comment.
Created issue for this.
|
I'd consider adding a skill (maybe with a sub-agent so the main context will stay clear), such that:
|
As part of the blueprint to RHOAI skill conversion, we also need an agent to deploy the project and debug deployment failures. I totally agree that this loop will save a lot of engineering time. However, we need to consider security, and we are checking the best options for how to restrict the agent while giving it enough freedom to deploy and debug on the cluster. |
Agreed. We may be missing an entire skill. We may need to make this an explcit step or ensure each stage has security considerations. I do not have ideas yet but we can brainstorm. |
| @@ -0,0 +1,123 @@ | |||
| # Sync and validate skills under core/skills/. | |||
There was a problem hiding this comment.
This is broken and needs a fix.
Description
This PR is to add functionality to the Quickstart Factory to create a new Quickstart from a user's idea all the way to the final product.
This include most of the SDLC for creating quickstart projects.
Changes
data/prds/<slug>.mddata/designs/<slug>.mdConsiderations
This was tested on my machine using an already pre-built quickstart project to see how well it would do.
Please test this out on your own machines to see how well it works for you. This is NOT production ready and should be used accordingly.
Please leave comments and feedback on the PR to help improve the quality of the quickstart factory.
Known Issues
ai-architecture-chartsrepo this can change.Example outputs
The entire repo was created by the skills here:
Then entire repo was created by the skills: