cmake: add ESPEAK_NG_VERSION#22
Conversation
this lets to specify a custom espeak-ng version See also: mudler/LocalAI#1356
|
I suggest that it uses a release tag from https://github.com/rhasspy/espeak-ng/releases The git sha1 is not friendly to human. A git tag is easier to read. |
I tend to disagree, both sha1 and tags are handy. However, the proposed solution works for both, so it shouldn't really matter. |
|
https://github.com/rhasspy/espeak-ng/archive/refs/tags/2023.9.7-4.zip https://github.com/rhasspy/espeak-ng/archive/5c3a2e79c24f92cd408d067a9aa47553927ec891.zip The above two links point to the same file. I think the first one is more descriptive. |
right, but doesn't really matter in term of this PR. You are free to express both with this implementation - it's up to you if you want to pick a sha or a tag. |
|
This PR is using I suggest using |
You can set refs/tags as part of ESPEAK_NG_VERSION. What's the value added in not allowing to specify Sha here? I personally find it useful and I'd like to be able to pinpoint to sha as well. |
2 participants
this allows to specify a custom espeak-ng version
See also: mudler/LocalAI#1356
Reasoning: rhasspy/espeak-ng#1 broke building against espeak-ng, and would ease out things if we could pinpoint to specific versions so to gate changes at CI level
cc @synesthesiam