Feedback implementation#17
Conversation
|
|
||
| describe('Navbar', () => { | ||
| let wrapper = shallow(<Navbar {...props} />); | ||
| console.log('nav-props', wrapper.props()); |
There was a problem hiding this comment.
Unexpected console statement no-console
| } | ||
| #full-edit { | ||
| margin: 10%; | ||
| margin-left: -50%; |
There was a problem hiding this comment.
Properties should be ordered margin, margin-bottom, margin-left, margin-top, width
| div.card-action.row{ | ||
| height: 9% | ||
| } | ||
| #full-edit { |
| } | ||
| div.card-action.row{ | ||
| height: 9% | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| import webpackConfig from '../webpack.config'; | ||
|
|
||
| import routes from './routes/index'; | ||
| import routes from './routes'; |
There was a problem hiding this comment.
Missing file extension for "./routes" import/extensions
|
|
||
| describe('Navbar', () => { | ||
| let wrapper = shallow(<Navbar {...props} />); | ||
| console.log('nav-props', wrapper.props()); |
There was a problem hiding this comment.
Unexpected console statement no-console
| name="password" | ||
| required | ||
| /> | ||
| <label htmlFor="new">Comfirm Password</label> |
There was a problem hiding this comment.
Form label must have associated control jsx-a11y/label-has-for
| name="lastName" | ||
| required | ||
| /> | ||
| <label htmlFor="new">Password</label> |
There was a problem hiding this comment.
Form label must have associated control jsx-a11y/label-has-for
| name="firstName" | ||
| required | ||
| /> | ||
| <label htmlFor="new">Last Name</label> |
There was a problem hiding this comment.
Form label must have associated control jsx-a11y/label-has-for
| onClick={this.updateFullProfile} | ||
| >Save | ||
| </Button> | ||
| ] |
There was a problem hiding this comment.
Expected indentation of 28 spaces but found 26 indent
| className="btn-save" | ||
| onClick={this.updateFullProfile} | ||
| >Save | ||
| </Button> |
There was a problem hiding this comment.
Expected indentation of 30 spaces but found 36 indent
Expected closing tag to match indentation of opening react/jsx-closing-tag-location
Expected indentation of 28 space characters but found 36 react/jsx-indent
| flat | ||
| className="btn-save" | ||
| onClick={this.updateFullProfile} | ||
| >Save |
There was a problem hiding this comment.
Expected indentation of 30 spaces but found 28 indent
| waves="light" | ||
| flat | ||
| className="btn-save" | ||
| onClick={this.updateFullProfile} |
There was a problem hiding this comment.
Expected indentation of 32 spaces but found 30 indent
| id="sav" | ||
| waves="light" | ||
| flat | ||
| className="btn-save" |
There was a problem hiding this comment.
Expected indentation of 32 spaces but found 30 indent
2 participants
No description provided.