Add read-only mode to allow cache reads but skip writes#9
Open
cchristous wants to merge 1 commit intorichardartoul:mainfrom
Open
Add read-only mode to allow cache reads but skip writes#9cchristous wants to merge 1 commit intorichardartoul:mainfrom
cchristous wants to merge 1 commit intorichardartoul:mainfrom
Conversation
This enables use cases where you want to pull from the cache but not populate it, such as running tests on feature branches without polluting the shared cache. - Add -read-only flag and GOBUILDCACHE_READ_ONLY env var - Skip PUT operations when enabled, returning success without writing - Add skippedPuts counter to stats output - Fix division-by-zero in stats when getCount or putCount is zero - Add unit tests for read-only mode behavior
| duplicateGets, float64(duplicateGets)/float64(getCount)*100) | ||
| fmt.Fprintf(os.Stderr, " Deduplicated GETs (singleflight): %d (%.1f%% of GETs)\n", | ||
| deduplicatedGets, float64(deduplicatedGets)/float64(getCount)*100) | ||
| if getCount > 0 { |
Owner
There was a problem hiding this comment.
can you remove this conditional so the output is uniform?
| if skippedPuts > 0 { | ||
| fmt.Fprintf(os.Stderr, " Skipped PUTs (read-only mode): %d\n", skippedPuts) | ||
| } | ||
| if putCount > 0 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-read-onlyflag andGOBUILDCACHE_READ_ONLYenvironment variable to enable read-only modeChanges
readOnlyfield,skippedPutscounter, skip logic inhandlePut, and fixed pre-existing division-by-zero bugs in stats output whengetCountorputCountis zeroTest plan
go test ./...)GOBUILDCACHE_READ_ONLY=trueto verify PUTs are skipped