Add filter log by "today"#17
Open
dhontecillas wants to merge 1 commit intorichmeta:masterfrom
dhontecillas:add_period
Open
Add filter log by "today"#17dhontecillas wants to merge 1 commit intorichmeta:masterfrom dhontecillas:add_period
dhontecillas wants to merge 1 commit intorichmeta:masterfrom
dhontecillas:add_period
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docs says that we can pass a today param to the
ti logcommand, but it is not implemented.I tried to add the functionality using a
Periodclass to check for intersections of time. I though that in the future we can improve and add more time periods, like "this week" , or "before 2018-01-01", and so one.I did not add unit test, because there is no file for tests yet, but I can add them if you are ok with it.