feat(countRows): support optional filters and maxPages override - #396
Conversation
countRows() now accepts optional filters and options ({ exact, maxPages })
to count only matching rows without materializing SmartRow objects.
Closes #394
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🤖 Bot HQ🔗 Issue Link🔗 Closes #394 🔍 AI Review
📊 This PR: $0.0445 · Repo today: $0.13 / $1.00 · Month: $1.27 / $10.00 Review History (1 round)
This comment is managed by the bot — do not edit directly. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AI ReviewPR #396 adds optional filters and maxPages override to countRows() with good backward compatibility. The implementation is solid with thorough test coverage (4 new E2E tests, 5 existing tests still passing). No critical bugs found.
|
|
Summary
countRows()now accepts optionalfiltersandoptions({ exact, maxPages }) parametersFilterEngineto count only matching rows without materializingSmartRowobjects — more efficient thanfindRows(filters).lengthcountRows()with no arguments behaves exactly as beforemaxPagesoverride lets callers limit pagination depth independently of the table-level configCloses #394
Test plan
countRowstests still pass (pagination, no-pagination, error recovery)pnpm run buildpasses — API docs and type context auto-regenerated🤖 Generated with Claude Code