Skip to content

feat(countRows): support optional filters and maxPages override - #396

Merged
rickcedwhat merged 2 commits into
mainfrom
feat/394-countrows-filters
Jul 28, 2026
Merged

feat(countRows): support optional filters and maxPages override#396
rickcedwhat merged 2 commits into
mainfrom
feat/394-countrows-filters

Conversation

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator

Summary

  • countRows() now accepts optional filters and options ({ exact, maxPages }) parameters
  • Applies FilterEngine to count only matching rows without materializing SmartRow objects — more efficient than findRows(filters).length
  • Backward-compatible: calling countRows() with no arguments behaves exactly as before
  • Per-call maxPages override lets callers limit pagination depth independently of the table-level config

Closes #394

Test plan

  • 4 new E2E tests: filtered count across pages, single-page filter, maxPages override, no-match returns 0
  • 5 existing countRows tests still pass (pagination, no-pagination, error recovery)
  • pnpm run build passes — API docs and type context auto-regenerated

🤖 Generated with Claude Code

countRows() now accepts optional filters and options ({ exact, maxPages })
to count only matching rows without materializing SmartRow objects.

Closes #394

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rickcedwhat-ai

rickcedwhat-ai commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Bot HQ

🔗 Issue Link

🔗 Closes #394


🔍 AI Review

  • 🔍 Request AI review

✅ Review complete — no blocking issues.

📊 This PR: $0.0445 · Repo today: $0.13 / $1.00 · Month: $1.27 / $10.00

Review History (1 round)
Round Date Commit In Tokens Out Tokens Cost Summary
1 2026-07-28 3e8400a 44,011 99 $0.0445 No issues found

This comment is managed by the bot — do not edit directly.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b36e473f-a38b-498b-a93d-3700a49b1a79

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/394-countrows-filters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

📖 Docs Preview — PR #396

Page Canonical Preview Compare
api/table-methods view preview compare

Open full compare view

Built from 3e8400a

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator Author

AI Review

PR #396 adds optional filters and maxPages override to countRows() with good backward compatibility. The implementation is solid with thorough test coverage (4 new E2E tests, 5 existing tests still passing). No critical bugs found.

✅ No actionable issues found.

@rickcedwhat
rickcedwhat merged commit 4b74457 into main Jul 28, 2026
14 checks passed
@rickcedwhat
rickcedwhat deleted the feat/394-countrows-filters branch July 28, 2026 22:41
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-28 22:41 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support filters in countRows()

2 participants