chore: fix remaining tech debt from GBU report (#351) - #397
Conversation
- Make sort stabilization timing configurable via LoadingStrategy fields: sortStabilizationTimeout, sortStabilizationPollInterval, sortStabilizationFallbackDelay (defaults preserve existing behavior) - Remove stale _isLocator comment in smartRow.ts 3 of 5 items from #351 were already fixed (#319 CodeQL pnpm ref, #320 dead _hasPaginated var, #325 generateConfig branding). Sentinel row index (#322 sub-item) and MUI 500ms delay also already resolved. Closes #322 Closes #351 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🤖 Bot HQ🔗 Issue Link🔍 AI Review
📊 This PR: $0.0395 · Repo today: $0.17 / $1.00 · Month: $1.31 / $10.00 Review History (1 round)
This comment is managed by the bot — do not edit directly. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AI ReviewThis PR makes sort stabilization timing configurable via three new optional LoadingStrategy fields (sortStabilizationTimeout, sortStabilizationPollInterval, sortStabilizationFallbackDelay) with backward-compatible defaults, and removes a stale comment. The changes are well-structured and preserve backward compatibility.
|
|
Summary
LoadingStrategyfields:sortStabilizationTimeout,sortStabilizationPollInterval,sortStabilizationFallbackDelay— all optional with backward-compatible defaults_isLocatorcomment insmartRow.ts_hasPaginatedvar), chore: generateConfig hardcodes "GEMINI / ChatGPT" vendor names #325 (generateConfigbranding)Closes #322, closes #351
Test plan
pnpm run buildpasses🤖 Generated with Claude Code