Skip to content

chore: fix remaining tech debt from GBU report (#351) - #397

Merged
rickcedwhat merged 1 commit into
mainfrom
chore/351-tech-debt-fixes
Jul 28, 2026
Merged

chore: fix remaining tech debt from GBU report (#351)#397
rickcedwhat merged 1 commit into
mainfrom
chore/351-tech-debt-fixes

Conversation

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator

Summary

Closes #322, closes #351

Test plan

  • 8 existing sorting tests pass
  • MUI DataGrid sort integration test passes
  • pnpm run build passes
  • Type-check clean

🤖 Generated with Claude Code

- Make sort stabilization timing configurable via LoadingStrategy fields:
  sortStabilizationTimeout, sortStabilizationPollInterval,
  sortStabilizationFallbackDelay (defaults preserve existing behavior)
- Remove stale _isLocator comment in smartRow.ts

3 of 5 items from #351 were already fixed (#319 CodeQL pnpm ref,
#320 dead _hasPaginated var, #325 generateConfig branding). Sentinel
row index (#322 sub-item) and MUI 500ms delay also already resolved.

Closes #322
Closes #351

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rickcedwhat-ai

rickcedwhat-ai commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Bot HQ

🔗 Issue Link

🔗 Closes #322, #351


🔍 AI Review

  • 🔍 Request AI review

✅ Review complete — no blocking issues.

📊 This PR: $0.0395 · Repo today: $0.17 / $1.00 · Month: $1.31 / $10.00

Review History (1 round)
Round Date Commit In Tokens Out Tokens Cost Summary
1 2026-07-28 1a5c34b 38,935 117 $0.0395 No issues found

This comment is managed by the bot — do not edit directly.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f692a3c1-65f7-461a-a907-76c84e69d96a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/351-tech-debt-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator Author

AI Review

This PR makes sort stabilization timing configurable via three new optional LoadingStrategy fields (sortStabilizationTimeout, sortStabilizationPollInterval, sortStabilizationFallbackDelay) with backward-compatible defaults, and removes a stale comment. The changes are well-structured and preserve backward compatibility.

✅ No actionable issues found.

@rickcedwhat
rickcedwhat merged commit d9acaf6 into main Jul 28, 2026
15 checks passed
@rickcedwhat
rickcedwhat deleted the chore/351-tech-debt-fixes branch July 28, 2026 23:05
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-28 23:06 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: 5 issues closed as completed without code fixes landing fix: sort stabilization timeout is hardcoded and not configurable

2 participants