Skip to content

feat: extract cross-pollination helpers from playwright-smart-table - #57

Closed
rickcedwhat-ai wants to merge 1 commit into
mainfrom
feat/cross-pollination-helpers
Closed

feat: extract cross-pollination helpers from playwright-smart-table#57
rickcedwhat-ai wants to merge 1 commit into
mainfrom
feat/cross-pollination-helpers

Conversation

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator

Summary

  • Adds waitForCondition — generic 100ms polling predicate with configurable timeout
  • Adds ElementTracker — browser-side WeakMap tracker for virtualized/recycled DOM lists (peek/commit pattern)
  • Adds levenshteinDistance / stringSimilarity / findSimilar — case-weighted fuzzy string matching for "did you mean?" style errors
  • Adds StabilizationStrategies (contentChanged, rowCountIncreased, networkIdle) — generalized from smart-table's version, adapted to (rows: Locator, page: Page, action) API without TableContext dependency

All four modules are zero-dependency (Playwright types only) and pass the existing 35-test suite.

Closes #32

Test plan

  • pnpm run build — clean compile, no TS errors
  • pnpm test — 35/35 pass

🤖 Generated with Claude Code

Adds four standalone utilities identified in issue #32:

- waitForCondition: generic 100ms-polling predicate with timeout
- ElementTracker: browser-side WeakMap tracker for virtualized/recycled
  DOM lists; supports peek/commit pattern for partial processing
- levenshteinDistance/stringSimilarity/findSimilar: case-weighted fuzzy
  string matching for did-you-mean style errors
- StabilizationStrategies: contentChanged, rowCountIncreased, networkIdle
  strategies generalized to (rows: Locator, page: Page, action) API,
  removing the playwright-smart-table TableContext dependency

Closes #32

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rickcedwhat-ai, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 31 minutes and 49 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e917be1f-cd38-406e-897a-d93af3f227a5

📥 Commits

Reviewing files that changed from the base of the PR and between 06cf065 and 5a5b17e.

📒 Files selected for processing (5)
  • src/elementTracker.ts
  • src/index.ts
  • src/stabilization.ts
  • src/stringUtils.ts
  • src/waitForCondition.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/cross-pollination-helpers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rickcedwhat-ai

Copy link
Copy Markdown
Collaborator Author

Closing — implementation was premature. Will revisit after design discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: candidates for cross-pollination from playwright-smart-table

1 participant