feat: extract cross-pollination helpers from playwright-smart-table - #57
feat: extract cross-pollination helpers from playwright-smart-table#57rickcedwhat-ai wants to merge 1 commit into
Conversation
Adds four standalone utilities identified in issue #32: - waitForCondition: generic 100ms-polling predicate with timeout - ElementTracker: browser-side WeakMap tracker for virtualized/recycled DOM lists; supports peek/commit pattern for partial processing - levenshteinDistance/stringSimilarity/findSimilar: case-weighted fuzzy string matching for did-you-mean style errors - StabilizationStrategies: contentChanged, rowCountIncreased, networkIdle strategies generalized to (rows: Locator, page: Page, action) API, removing the playwright-smart-table TableContext dependency Closes #32 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 31 minutes and 49 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — implementation was premature. Will revisit after design discussion. |
Summary
waitForCondition— generic 100ms polling predicate with configurable timeoutElementTracker— browser-side WeakMap tracker for virtualized/recycled DOM lists (peek/commit pattern)levenshteinDistance/stringSimilarity/findSimilar— case-weighted fuzzy string matching for "did you mean?" style errorsStabilizationStrategies(contentChanged,rowCountIncreased,networkIdle) — generalized from smart-table's version, adapted to(rows: Locator, page: Page, action)API withoutTableContextdependencyAll four modules are zero-dependency (Playwright types only) and pass the existing 35-test suite.
Closes #32
Test plan
pnpm run build— clean compile, no TS errorspnpm test— 35/35 pass🤖 Generated with Claude Code