We are not croaking when the plugin fails.#2
Open
oylenshpeegul wants to merge 1 commit intoriemann42:masterfrom
Open
We are not croaking when the plugin fails.#2oylenshpeegul wants to merge 1 commit intoriemann42:masterfrom
oylenshpeegul wants to merge 1 commit intoriemann42:masterfrom
Conversation
$ perl -MMusic::Tag -E 'Music::Tag->new(shift) and say "why are we here?"' foo.mp7 Music::Tag::Auto Sorry, I can't find a plugin for /home/tim/foo.mp7 at /home/tim/perl5/perlbrew/perls/perl-5.12.4/lib/site_perl/5.12.4/Music/Tag.pm line 146 why are we here?
Author
|
I made that change to a different Perl... $ perlbrew switch perl-5.14.2 The empty die caused the croak to be reached (no "why are we here?" line). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the croaks that follow do the right thing, but they're not getting the information they need.
$ perl -MMusic::Tag -E 'Music::Tag->new(shift) and say "why are we here?"' foo.mp7
Music::Tag::Auto Sorry, I can't find a plugin for /home/tim/foo.mp7 at /home/tim/perl5/perlbrew/perls/perl-5.12.4/lib/site_perl/5.12.4/Music/Tag.pm line 146
why are we here?