Repository navigation
Explorer Account page revamp: Balances, Summary and Assets #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
19a32b6
Account page refactoring - account header, account summary and accoun…
kuan121 864d98d
no message
kuan121 e8e7fdd
Add console logs for asset components
kuan121 a6bbab4
Update heldIOUs
kuan121 0cda16e
Simplify NFT code
kuan121 3600f53
Handle transfer fee and frozen status for held IOUs
kuan121 8776f5b
Handle issued IOUs
kuan121 97f27ac
New commit
kuan121 997cd0e
Use hardcoded LOS endpoints temporarily in IOUs asset components
kuan121 b2a434e
Add spinning circle to asset tab button when data is loading in addit…
kuan121 51974bc
Rename CurrencyOption to NumberFormatOption
kuan121 a33e462
Extract common USD and Balance formatting logic into utils file
kuan121 0c23b57
Exclude frozen balance from Issued IOU supply
kuan121 05c3be6
Delete old account asset/token components
kuan121 df02a38
Update non en-US translation files
kuan121 b82de6e
Remove unused translations that were used in old account asset compon…
kuan121 d5573a6
Make the two Asset sections collapsable for better UX on mobile view
kuan121 0445c48
Use the USD price of IOU token from LOS Token API
kuan121 3224aa4
Increase limit of getNFTsIssuedByAccount from 25 to 50
kuan121 c30fe65
Read LOS API from env variable
kuan121 e6850ad
Move shortenXyz methods from rippled/lib/utils.js to shared/utils.js
kuan121 510d679
Replace browser built-in tooltip with the Explorer custom tooltip to …
kuan121 e153c3a
Add missing translations for account flag title and reorder some tran…
kuan121 13da037
Minor updates: reduce font-size for No Tokens Found text and replace …
kuan121 3b7e50a
Handle exception thrown from getBalances call
kuan121 70d9883
Create getAMMInfoByAMMAccount and getAMMInfoByAssets
kuan121 c98fdea
Minor refactoring of HeldLPTokens.tsx
kuan121 2c17472
Update how to detect LP Tokens in IOU components
kuan121 b540bd5
CSS update to transaction header to make it match other headers on th…
kuan121 dbfc506
Remove info console logs to avoid logging debug logs in production
kuan121 048e679
Rename shortAccount to displayText for Account.tsx
kuan121 3f40bc5
Add tests for formatTransferFee
kuan121 5b2df14
Add unit tests for FutureDataIcon.tsx
kuan121 28e2de2
Replace magic numbers with constants
kuan121 273bf74
Add unit tests for 7 asset table components and the main AccountAsset…
kuan121 3d5c5f5
Add unit test for AccountHeader.tsx
kuan121 1a85708
Fixed failed unit tests for AccountTransactionTable.tsx
kuan121 a28d6b2
More unit tests for AccountAsset index.tsx
kuan121 5be7e53
Add unit tests for AccountSummary components
kuan121 5a2b997
Fixed failed tests for Accounts/index.test.tsx and updated tests to R…
kuan121 89ed0bd
Fix typescript-check errors
kuan121 b4e7dd4
Fix linting errors
kuan121 4bc0d52
Add and updated unit tests for existing and new functions and components
kuan121 60db069
package-lock.json update by running `npm-install` to add new dependen…
kuan121 d38b28f
UX improvement to Held IOUs: show the IOUs table immediately, then pr…
kuan121 e9debef
Make changes to the titles, descriptions and status value to some Acc…
kuan121 41fed1a
Update unit tests for HeldIOUs.tsx to verify the logic of sorting by …
kuan121 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could we update the example to the prod url just in the rare case that someone tries to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing purpose, I think dev endpoint should be sufficient. In general, it's not a good idea to expose prod endpoint even though we have DDoS protection in place.