fix(pitchfork): trust proxy ca in windows - #3876
Merged
risu729 merged 2 commits intoJul 27, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConfigures Pitchfork on WSL/Windows to rely on native *.localhost resolution while automatically trusting the Pitchfork-generated proxy CA in the Windows current-user root store, skipping re-import when the same certificate is already trusted. Sequence diagram for Pitchfork CA import during bootstrapsequenceDiagram
participant BootstrapScript
participant PowerShell
participant Certutil
participant WindowsCertStore
BootstrapScript->>PowerShell: powershell.exe -NoProfile -Command
PowerShell->>PowerShell: X509Certificate2.new(CertPath)
PowerShell->>WindowsCertStore: Test-Path Cert:\CurrentUser\Root\Thumbprint
alt [thumbprint not present]
PowerShell->>Certutil: certutil.exe -user -f -addstore Root CertPath
Certutil->>WindowsCertStore: add Pitchfork_CA to Root
else [thumbprint already trusted]
PowerShell->>PowerShell: skip import
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the PowerShell snippet, consider quoting
$CertPathwhen passing it tocertutil.exeto avoid failures if the Windows path contains spaces (e.g."$CertPath"). - It may be helpful to add a small success/failure message around the CA import so that users can distinguish between a skipped import (already trusted) and a failed
certutilrun when troubleshooting.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the PowerShell snippet, consider quoting `$CertPath` when passing it to `certutil.exe` to avoid failures if the Windows path contains spaces (e.g. `"$CertPath"`).
- It may be helpful to add a small success/failure message around the CA import so that users can distinguish between a skipped import (already trusted) and a failed `certutil` run when troubleshooting.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
risu729
merged commit Jul 27, 2026
8703bc7
into
agent/restore-pitchfork-schema-strictness
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.localhostresolutionValidation
mise exec -- hk checkhttps://pitchfork.localhost/with certificate validation enabled (--ssl-no-revoke) and returns HTTP 200Stack
Stacked on #3874, which restores strict validation for the same Pitchfork config.
Summary by Sourcery
Trust Pitchfork’s local proxy CA on Windows clients and rely on native localhost resolution instead of hosts-file synchronization.
Bug Fixes:
Enhancements: