repo update with new billboard architecture and several new nodejs workspaces and testing tools - #5
repo update with new billboard architecture and several new nodejs workspaces and testing tools#5ritorhymes wants to merge 176 commits into
Conversation
…l centering and H's scaling on mobile
Move wagmi/Web3Modal setup into shared foundation with lazy loading and cached clients Make header connect button use shared loader, always open modal, and eager-load when a prior session exists (optional opt-in/out hook) Refactor buy/personalize pages to reuse ensureConnected helper for tx flows, removing duplicate wagmi setup
Add shared mainnet guard to lazy Web3 foundation exposing wagmi switchNetwork with alert fallback when switching fails Wire mainnet guard into buy/personalize transaction flows so they only proceed after connect plus mainnet check
Homepage main image tooltip now overflows instead of being hidden around edges Homepage image squares become deselected when cursor leaves the image Homepage recent squares activity components reformatted to prevent overflow and stack vertically on mobile and horizontally on desktop personalize-batch now uses same CSS as personalize page for consistency
Move images into dedicated image folder Move modal folders into master modal folder Refactor main.css into more maintainable dedicated page-specific ones, and move into CSS folder Adjust font and space sizing for greater consistency Establish CSS variables and replaced hard coded values Make custom stylized scroll bar universal All imports updated for moved assets Turn white paper article list into unordered list with reduced gap Add additional break point for home page newly-minted newly-personalized to stack on smaller screens Add FAQ link to main menu modal
Renamed modal.css to nav.css to better reflect content Added semantic <nav> elements with aria-label attributes for screen readers Converted articles link to <button> with aria-controls for proper semantics Added aria-controls to back button Added aria-label to Connect Wallet button
Refactored square lookup into a reusable component used on homepage and square.html Added validation logic to square lookup form field (1–10,000 and minted-only alert) Adjusted square lookup layout Implemented mobile responsive grid structure for chooser buttons Integrated square choosers into buy.html flow configured for unminted Squares
… look of Articles button
…on unless a square is actively highlighted
…with viewport width
- buy test - legacy personalize pages and unpersonalization tests - reusable connect wallet flow - rpc mock supports image uploads; refactored into extensible architecture
…o personalize table
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02eba1ae13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const pick = (key, fallback) => { | ||
| const val = bases[key]; | ||
| const path = (val && typeof val === "string") ? val : fallback; | ||
| // Prepend baseurl if path doesn't already include it | ||
| if (baseurl && !path.startsWith(baseurl)) { | ||
| return joinBaseUrl(baseurl, path); | ||
| } |
There was a problem hiding this comment.
The asset base normalization unconditionally prefixes SITE_BASEURL when the path doesn't start with the baseurl. That breaks legitimate absolute asset bases (e.g. ASSET_BASE_MAINNET=https://cdn.example.com/build): the resulting URL becomes /repohttps://cdn.example.com/build, so all asset fetches 404 in that configuration. This only occurs when a CDN or full URL is configured, but the runtime config explicitly supports custom ASSET_BASE_* values, so this is a realistic setup. Consider skipping the baseurl prefix when the path is already absolute (e.g., starts with http://, https://, or //).
Useful? React with 👍 / 👎.
1 participant
No description provided.